🚀 [Story performance] Launch first page load experiment to 10%#35192
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
kristoferbaxter
left a comment
There was a problem hiding this comment.
Left a nit for a future consideration.
| if (isExperimentOn(this.win, 'story-load-first-page-only')) { | ||
| Services.performanceFor(this.win).addEnabledExperiment( | ||
| 'amp-story-load-first-page-only' | ||
| 'story-load-first-page-only' |
There was a problem hiding this comment.
Nit: This appears a bit strange, why does amp-story read for the value of an experiment followed by only setting the same value for elsewhere?
There was a problem hiding this comment.
Please let us know if we're missing something:
The CSI pipeline doesn't track experiments by defaults, we need to specifically enable them through this method so they appear in our dashboards. We'll want to monitor the LCP improvements for this experiment before launching fully.
There was a problem hiding this comment.
Don't think you're missing anything, but we should revisit this later on.
CSI should automatically insert all tests so we don't have to remember to do this.
Launches the
story-load-first-page-onlyexperiment to 10%.Also, since experiments don't start with
amp-(everything is amp), removed the prefixamp-from the experiment name