🖍 [Story interactive] Post-Selection Animations for Image Quizzes and Image Polls#35205
Merged
processprocess merged 5 commits intoJul 14, 2021
Conversation
|
Hey @gmajoulet, @mszylkowski! These files were changed: |
mszylkowski
approved these changes
Jul 13, 2021
processprocess
approved these changes
Jul 13, 2021
Comment on lines
+74
to
+75
| transform: scaleY(0%) !important; | ||
| transform-origin: bottom !important; |
| } | ||
|
|
||
| .i-amphtml-story-interactive-img-option-img::before { | ||
| background-color: var(--i-amphtml-interactive-option-post-color) !important; |
Contributor
There was a problem hiding this comment.
There is a flaky diff that might be due to this being set before there is data.
Moving this line to the post state might fix the flaky diff.
calebcordry
pushed a commit
that referenced
this pull request
Jul 20, 2021
* 🖍 [Story interactive] Post-Selection Animations for Image Quizzes and Image Polls (#35205) * Add fill animation * Add bubble post-selection animation * Move background color percentage fill to post selection styles * Fix tests and address nits * Fix regex * Fix const reassignment * Disable when invalid site id, fix lint * Update test * Test fix * Fix zindex * Fix toc Co-authored-by: Brandon Suen <brandonbsuen@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Establishes animations upon selection of an option for image quizzes and polls including scaling up the fill that shows the percentage who chose that option and creating a bouncing effect for A/B/C/D bubbles for quizzes
Demos:
https://interactive-img.web.app/post-selection-animations/quiz.html
https://interactive-img.web.app/post-selection-animations/poll.html
Closes #35184
/cc @mszylkowski
/cc @processprocess