Skip to content

Improve library performance; Make scrolling use CSS rather than JS; Add unit tests and fix code following them. #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WebCoder49 merged 12 commits into from
Feb 12, 2024
Merged

Improve library performance; Make scrolling use CSS rather than JS; Add unit tests and fix code following them. #76

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
897eb60
Merge pull request #74 from WebCoder49/main
WebCoder49 Dec 15, 2023
dd1fc54
Started speeding up updates using requestAnimationFrame; Ctrl+F fix s…
WebCoder49 Dec 15, 2023
0c3af7c
Some compatibility changes in plugins; disabled messy Ctrl+F fix for now
WebCoder49 Dec 15, 2023
e63e6d8
Fix some CSS for line-numbers plugin
WebCoder49 Dec 15, 2023
9f835ba
Allow scrolling when highlight.js
WebCoder49 Dec 17, 2023
c91d9da
Remove old fix for Ctrl+F due to its inconsistency
WebCoder49 Jan 20, 2024
1df873a
Add tests, make work for Prism; Clean up code
WebCoder49 Feb 10, 2024
65a32fa
Finish tests; fix code so they should work with Prism
WebCoder49 Feb 10, 2024
62fa9fa
Clean Up Plugin Comment
WebCoder49 Feb 11, 2024
672a45c
Get all tests working for HLJS+Prism except for HLJS autocomplete
WebCoder49 Feb 11, 2024
fd08758
Finish tests; make code work with all tests
WebCoder49 Feb 12, 2024
79ce263
Clarify contributing guidelines for tests
WebCoder49 Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Clarify contributing guidelines for tests
  • Loading branch information
@WebCoder49
WebCoder49 committed Feb 12, 2024
commit 79ce263b3be39c4c5e49e1d2cb37283954ce9b67
2 changes: 2 additions & 0 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,6 @@ Firstly, thank you for doing this! This is probably the most time consuming way

Please first open an issue if one doesn't already exist, and assign yourself to it. Then, [make a fork of the repo and submit a pull request](https://docs.github.com/en/get-started/quickstart/contributing-to-projects).

In the pull request, include the code updates for your feature / bug, and if you're adding a new feature make sure you comment your code so it's understandable to future contributors, and if you can, add unit tests for it in tests/tester.js. If you have any questions, just let me (@WebCoder49) know!

If an issue is open but already assigned to someone, it is probably already being worked on - you could still suggest a method of fixing it in the comments but shouldn't open a pull request as it would waste your time.