Skip to content

Add Matter HRAP Support#2283

Merged
hcarter-775 merged 1 commit into
mainfrom
add-matter-hrap
Aug 22, 2025
Merged

Add Matter HRAP Support#2283
hcarter-775 merged 1 commit into
mainfrom
add-matter-hrap

Conversation

@hcarter-775
Copy link
Copy Markdown
Contributor

@hcarter-775 hcarter-775 commented Jul 25, 2025 •
edited
Loading

Description of Change

Implements handling for the TBR and NIM Device Types. Includes a basic thread operational dataset parser.

Summary of Completed Tests

Tested using CHIP Example App, VDA, and is verified with unit tests.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 25, 2025

Duplicate profile check: Passed - no duplicate profiles detected.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 25, 2025 •
edited
Loading

Channel deleted.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 25, 2025 •
edited
Loading

File Coverage
All files NaN% ❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against cd8e8fa

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 25, 2025 •
edited
Loading

Test Results

   69 files    448 suites   0s ⏱️
2 325 tests 2 325 ✅ 0 💤 0 ❌
3 924 runs  3 924 ✅ 0 💤 0 ❌

Results for commit cd8e8fa.

♻️ This comment has been updated with latest results.

nickolas-deboom
nickolas-deboom reviewed Jul 30, 2025
View reviewed changes
Comment thread drivers/SmartThings/matter-hrap/src/init.lua
nickolas-deboom
nickolas-deboom reviewed Jul 30, 2025
View reviewed changes
Comment thread drivers/SmartThings/matter-hrap/src/init.lua
nickolas-deboom
nickolas-deboom reviewed Jul 30, 2025
View reviewed changes
Comment thread drivers/SmartThings/matter-hrap/src/init.lua
nickolas-deboom
nickolas-deboom reviewed Jul 30, 2025
View reviewed changes
Comment thread drivers/SmartThings/matter-hrap/src/init.lua
@nickolas-deboom
Copy link
Copy Markdown
Contributor

nickolas-deboom commented Aug 1, 2025

I looked over the cluster-capability mappings again and passed over the driver again and things look good from my perspective. One more question I had is have you tested using the embedded cluster definitions?

@hcarter-775
Copy link
Copy Markdown
Contributor Author

hcarter-775 commented Aug 1, 2025

I looked over the cluster-capability mappings again and passed over the driver again and things look good from my perspective. One more question I had is have you tested using the embedded cluster definitions?

Good callout! Yes, this has been tested now. There actually was a small typo bug that got fixed in the latest commit

@HunsupJung
Copy link
Copy Markdown
Collaborator

HunsupJung commented Aug 7, 2025

@hcarter-775
I tested it with VDA (1.4.8) and there's no issue.

nand-nor
nand-nor approved these changes Aug 13, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@nand-nor nand-nor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work Harrison!

@hcarter-775 hcarter-775 force-pushed the add-matter-hrap branch 2 times, most recently from 75fe862 to 85bd6ca Compare August 18, 2025 18:15
ctowns
ctowns reviewed Aug 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ctowns ctowns left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Harrison! I appreciate the helpful comments that are included throughout, and the organization of the handlers is very clean 💯

Comment thread drivers/SmartThings/matter-hrap/src/init.lua Outdated
Comment thread drivers/SmartThings/matter-hrap/src/init.lua
Comment thread drivers/SmartThings/matter-hrap/src/init.lua Outdated
Comment thread drivers/SmartThings/matter-hrap/src/init.lua
Comment thread drivers/SmartThings/matter-hrap/src/init.lua Outdated
Comment thread drivers/SmartThings/matter-hrap/src/init.lua Outdated
Comment thread drivers/SmartThings/matter-hrap/src/init.lua
Comment thread drivers/SmartThings/matter-hrap/src/init.lua
Comment thread drivers/SmartThings/matter-hrap/src/init.lua Outdated
ctowns
ctowns reviewed Aug 19, 2025
View reviewed changes
Comment thread drivers/SmartThings/matter-hrap/src/init.lua Outdated
ctowns
ctowns reviewed Aug 20, 2025
View reviewed changes
Comment thread drivers/SmartThings/matter-hrap/src/init.lua Outdated
ctowns
ctowns approved these changes Aug 20, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ctowns ctowns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more small comment, otherwise this looks good to me!

@hcarter-775 hcarter-775 force-pushed the add-matter-hrap branch 2 times, most recently from 7c97195 to 304cbf1 Compare August 20, 2025 21:47
@hcarter-775 hcarter-775 merged commit 59768f1 into main Aug 22, 2025
12 checks passed
@hcarter-775 hcarter-775 deleted the add-matter-hrap branch August 22, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nand-nor nand-nor nand-nor approved these changes

@ctowns ctowns ctowns approved these changes

@HunsupJung HunsupJung HunsupJung approved these changes

@nickolas-deboom nickolas-deboom nickolas-deboom approved these changes

@tpmanley tpmanley Awaiting requested review from tpmanley

@z-michel z-michel Awaiting requested review from z-michel

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hcarter-775 @nickolas-deboom @HunsupJung @nand-nor @ctowns