Skip to content

Remove health check from zigbee thermostat#1814

Merged
cjswedes merged 1 commit into
mainfrom
feature/remove-health-check-zb-thermostat
Dec 10, 2024
Merged

Remove health check from zigbee thermostat#1814
cjswedes merged 1 commit into
mainfrom
feature/remove-health-check-zb-thermostat

Conversation

@cjswedes
Copy link
Copy Markdown
Contributor

This is not needed to keep device online, and so its being removed to gain the small memory/latency savings of having it disabled. Tested with a Sinope thermostat.

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

This is not needed to keep device online, and so its being removed to
gain the small memory/latency savings of having it disabled.
Tested with a Sinope thermostat
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 10, 2024

Channel deleted.

@github-actions
Copy link
Copy Markdown

Test Results

   64 files    402 suites   0s ⏱️
2 000 tests 2 000 ✅ 0 💤 0 ❌
3 455 runs  3 455 ✅ 0 💤 0 ❌

Results for commit e1f5669.

@github-actions
Copy link
Copy Markdown

File Coverage
All files 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/aqara/init.lua 78%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/leviton/init.lua 89%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/vimar/init.lua 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/zenwithin/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro/init.lua 88%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/resideo_korea/init.lua 81%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/lux-konoz/init.lua 91%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/init.lua 97%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/popp/init.lua 78%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/sinope/init.lua 92%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zigbee-thermostat/src/stelpro-ki-zigbee-thermostat/init.lua 89%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against e1f5669

@cjswedes cjswedes merged commit 0ccdd93 into main Dec 10, 2024
@cjswedes cjswedes deleted the feature/remove-health-check-zb-thermostat branch December 10, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants