Skip to content

feat: Add avatars #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
orronai wants to merge 14 commits into
base: master
Choose a base branch
from
Open

feat: Add avatars #331

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c3e3d66
feat: Add avatars
orronai Oct 10, 2021
d50bfda
'Refactored by Sourcery' (#332)
sourcery-ai[bot] Oct 10, 2021
657715e
Added the mkdir of the avatars path if it doesn't exist
orronai Oct 10, 2021
215b341
- Merged with master
orronai Oct 11, 2021
d2d51e7
Merge branch 'master' of https://github.com/PythonFreeCourse/lms into…
orronai Oct 15, 2021
7f44c03
Image saving proccess is now async
orronai Oct 15, 2021
ddd195f
fixed translations
orronai Oct 15, 2021
1fb34b9
fixed asyncio test
orronai Oct 15, 2021
2314d37
fixed asyncio test
orronai Oct 15, 2021
997899f
fixed asyncio test
orronai Oct 15, 2021
b1de37a
fixed asyncio test
orronai Oct 15, 2021
791fd06
fix merge conflicts
orronai Oct 15, 2021
f647f9e
Merge branch 'master' into edit-profile
orronai Oct 19, 2021
3052f0b
removed unnecessary line
orronai Oct 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed asyncio test
  • Loading branch information
@orronai
orronai committed Oct 15, 2021
commit 1fb34b9fc83211cd5f827fc12cc78c0abdc3ec12
8 changes: 5 additions & 3 deletions tests/test_users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
from unittest.mock import Mock, patch

from flask.testing import FlaskClient
import pytest
from werkzeug.datastructures import FileStorage

from lms.lmsdb.models import Course, User
Expand Down Expand Up @@ -244,12 +245,13 @@ def teardown(self):
def open_file(filename: str) -> BufferedReader:
return open(Path(conftest.SAMPLES_DIR) / filename, 'br')
Copy link
Copy Markdown
Member

@yammesicka yammesicka Oct 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can do it with fixture: use file_handler = open(...), then yield file_handler and finally file_handler.close it


def test_upload_avatar(self, student_user: User, captured_templates):
@pytest.mark.asyncio
async def test_upload_avatar(self, student_user: User, captured_templates):
client = conftest.get_logged_user(student_user.username)
conftest.upload_avatar(client, self.image_storage)
await conftest.upload_avatar(client, self.image_storage)
template, _ = captured_templates[-1]
assert template.name == "user.html"
conftest.upload_avatar(client, self.image_storage_2)
await conftest.upload_avatar(client, self.image_storage_2)
client.get('/avatar/delete')
template, _ = captured_templates[-1]
assert template.name == "user.html"
Expand Down