Fix some numbers and Add some internal configurations#6779
Closed
taroarai wants to merge 1 commit intoMicrosoftDocs:livefrom
Closed
Fix some numbers and Add some internal configurations#6779taroarai wants to merge 1 commit intoMicrosoftDocs:livefrom
taroarai wants to merge 1 commit intoMicrosoftDocs:livefrom
Conversation
Here are my research result for each configuration that is different from SQL Server 2019. - access check cache bucket count From the code, it use 16384 for x86 and 65536 for x64, but as all supported versions are x64 only now, I change it to 65536. - ADR cleaner retry timeout (min) Actual default values is 0 when first started after clean setup, but I'm still investigating if 0 is ok or not. - ADR Preallocation Factor Actual default values is 0 when first started after clean setup, but when 0 is set, it will use 4 from the code. - allow filesystem enumeration I think it is internal, but customers can see from sp_configure or sys.configurations, we should document this, so some customers happen to changed, they can change back to default. - column encryption enclave type Max values is 2 from sp_configure or sys.configurations, but 1 is supported value as VSM. I guess 2 is used for Azure SQL Database with SGX. - min server memory (MB) Run_value will use 16 MB if Configure_values is lower, so I added a comment. - version high part of SQL Server / version low part of SQL Server It is also internal, and used for replicated master, but the same as "allow filesystem enumeration", customers can see it, so it is better to have default values on here.
Contributor
|
@taroarai : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Collaborator
|
@taroarai Taro, thanks for the suggestions! @MikeRayMSFT Mike, could you take a look at this while Mark is out of the office? Thank you! #reassign:mikeraymsft |
Contributor
|
Requesting review or reviewer recommendation from @pmasl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are my research result for each configuration that is different from SQL Server 2019.
access check cache bucket count
From the code, it use 16384 for x86 and 65536 for x64, but as all supported versions are x64 only now, I change it to 65536.
ADR cleaner retry timeout (min)
Actual default values is 0 when first started after clean setup, but I'm still investigating if 0 is ok or not.
ADR Preallocation Factor
Actual default values is 0 when first started after clean setup, but when 0 is set, it will use 4 from the code.
allow filesystem enumeration
I think it is internal, but customers can see from sp_configure or sys.configurations, we should document this, so some customers happen to changed, they can change back to default.
column encryption enclave type
Max values is 2 from sp_configure or sys.configurations, but 1 is supported value as VSM.
I guess 2 is used for Azure SQL Database with SGX.
min server memory (MB)
Run_value will use 16 MB if Configure_values is lower, so I added a comment.
version high part of SQL Server / version low part of SQL Server
It is also internal, and used for replicated master, but the same as "allow filesystem enumeration", customers can see it, so it is better to have default values on here.