Update install-additional-r-packages-on-sql-server.md#6538
Merged
ktoliver merged 1 commit intoMicrosoftDocs:livefrom Jun 29, 2021
Merged
Update install-additional-r-packages-on-sql-server.md#6538ktoliver merged 1 commit intoMicrosoftDocs:livefrom
ktoliver merged 1 commit intoMicrosoftDocs:livefrom
Conversation
Contributor
monamaki
commented
Jun 23, 2021
- https://github.com/Microsoft/sqlmlutils/tree/master/R/dist goes to an old sqlmlutils, not the releases tab. So, customers may download an old version.
- Updating R.exe -e "install.packages('odbc')" to R.exe -e "install.packages('odbc', type='binary')" (to be consistent with the github readme https://github.com/microsoft/sqlmlutils and customer don't get dependency related errors)
- https://github.com/Microsoft/sqlmlutils/tree/master/R/dist goes to an old sqlmlutils, not the releases tab. So, customers may download an old version. - Updating R.exe -e "install.packages('odbc')" to R.exe -e "install.packages('odbc', type='binary')" (to be consistent with the github readme https://github.com/microsoft/sqlmlutils and customer don't get dependency related errors)
Contributor
|
@monamaki : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
Author
|
@Aniruddh25 @guitarnana |
jarupatj
approved these changes
Jun 24, 2021
Contributor
|
@guitarnana Thank you for your review. In this repo, the article author or a PM should sign off before a pull request is merged. @garyericson Could you take a look? Thanks. |
garyericson
approved these changes
Jun 29, 2021
Contributor
garyericson
left a comment
There was a problem hiding this comment.
These changes look good. Thanks for catching this and making the updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.