Update dma-sku-recommend-sql-db.md#5613
Merged
ktoliver merged 3 commits intoMicrosoftDocs:livefrom Nov 19, 2020
Merged
Conversation
Removed the quotes around the connection string in the sample invocation for the data collection script, those quotes stop the script from connecting to the database Added a note about the WMI cmdlets needing to be updated to the CIM cmdlets to run the data collection script in Powershell 6 or 7.
Contributor
|
@Fronzoli : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Collaborator
|
Reassigning to @neetusingh-ms for review. Neetu, can you please review the changes on the File Changes tab and see if you approve this suggestion from @Fronzoli? Thank you! #reassign:neetusingh-ms |
haitsongmsft
approved these changes
Nov 3, 2020
Contributor
|
Hi @neetusingh-ms Could you review this pull request per the request from @rothja? Thanks! |
neetusingh-ms
approved these changes
Nov 18, 2020
Contributor
|
@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
Contributor
|
@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both changes made in Data Collection Script section
Removed the quotes around the connection string in the sample invocation for the data collection script, those quotes stop the script from connecting to the database
Added a note about the WMI cmdlets needing to be updated to the CIM cmdlets to run the data collection script in Powershell 6 or 7.