feat(pubsub): add clear export subscription samples#3159
Closed
hongalex wants to merge 15 commits into
Closed
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
telpirion
approved these changes
Jun 5, 2023
Contributor
telpirion
left a comment
There was a problem hiding this comment.
Only nits. Feel free to merge when status is green.
…-samples into feat-pubsub-clear-bq-sub
Collaborator
|
Hi @hongalex, This PR looks to be pretty stale, and need some attention to get the tests passing. I'll move it to Draft for now, but please reach out if you need any help getting this PR merged. |
93fe9b0 to
edc3292
Compare
Contributor
Contributor
Author
|
Closing due to staleness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR corresponds to the changes in googleapis/google-cloud-go#8040. We currently were not catching an issue where clearing bigquery subscription fails. This adds the appropriate sample + test to catch this. A similar sample and test is added for Push (to endpoint) subscriptions.
This PR also switches the BQ dataset/table used from dynamically created to a reused one. Since we aren't actually writing to these tables, there's no harm in reusing a predefined table. This prevents a slow leakage of tables/datasets over time when tests invocations inevitably fail.