Skip to content

chore(deps): Update Go SDK to include grpc writer fix [WIP]#4742

Open
krishnamd-jkp wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
krishnamd-jkp:go_sdk_grpc_race_fix
Open

chore(deps): Update Go SDK to include grpc writer fix [WIP]#4742
krishnamd-jkp wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
krishnamd-jkp:go_sdk_grpc_race_fix

Conversation

@krishnamd-jkp
Copy link
Copy Markdown
Collaborator

@krishnamd-jkp krishnamd-jkp commented May 29, 2026

Description

Update Go SDK to include grpc writer fix

Link to the issue in case of a bug fix.

Testing details

  1. Manual - NA
  2. Unit tests - NA
  3. Integration tests - Run as presubmits

Any backward incompatible change? If so, please explain.

@krishnamd-jkp krishnamd-jkp requested a review from a team as a code owner May 29, 2026 09:47
@krishnamd-jkp krishnamd-jkp requested a review from raj-prince May 29, 2026 09:47
@krishnamd-jkp krishnamd-jkp changed the title chore(deps): Update Go SDK to include grpc writer fix chore(deps): Update Go SDK to include grpc writer fix [WIP} May 29, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a series of dependency updates in the go.mod and go.sum files. The changes involve adjusting specific versions of Google Cloud and OpenTelemetry packages to address compatibility or functionality requirements, specifically targeting a fix related to the gRPC writer.

Highlights

  • Dependency Updates: Updated several Go module dependencies, including downgrading cloud.google.com/go/profiler and cloud.google.com/go/storage, as well as go.opentelemetry.io/otel/exporters/stdout/stdoutmetric.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@krishnamd-jkp krishnamd-jkp changed the title chore(deps): Update Go SDK to include grpc writer fix [WIP} chore(deps): Update Go SDK to include grpc writer fix [WIP] May 29, 2026
@krishnamd-jkp krishnamd-jkp added the execute-perf-test Execute performance test in PR label May 29, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request downgrades several dependencies in go.mod and go.sum, including cloud.google.com/go/profiler, cloud.google.com/go/storage, and go.opentelemetry.io/otel/exporters/stdout/stdoutmetric. Feedback was provided regarding the downgrade of cloud.google.com/go/profiler from v0.6.0 to v0.5.0, suggesting it be restored to avoid reverting potential bug fixes or performance improvements unless specifically required.

Comment thread go.mod
cloud.google.com/go/compute/metadata v0.9.0
cloud.google.com/go/iam v1.11.0
cloud.google.com/go/profiler v0.6.0
cloud.google.com/go/profiler v0.5.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The dependency cloud.google.com/go/profiler was downgraded from v0.6.0 to v0.5.0. Downgrading dependencies can revert bug fixes or performance improvements. Please restore it to v0.6.0 unless there is a specific compatibility requirement necessitating the older version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

execute-perf-test Execute performance test in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant