feat(cfg): add safe configuration and storage API for MRD connection pool autoscaling#4739
Draft
PranjalC100 wants to merge 2 commits into
Draft
feat(cfg): add safe configuration and storage API for MRD connection pool autoscaling#4739PranjalC100 wants to merge 2 commits into
PranjalC100 wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4739 +/- ##
===========================================
+ Coverage 0 83.71% +83.71%
===========================================
Files 0 168 +168
Lines 0 20752 +20752
===========================================
+ Hits 0 17372 +17372
- Misses 0 2734 +2734
- Partials 0 646 +646
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the new configuration parameters, validation logic, and storage layer interface fields for the Multi-Range Downloader (MRD) connection pool autoscaling feature.
Specifically, it adds:
mrd.max-connections: The maximum number of concurrent TCP connections allowed.mrd.min-connections: The minimum number of concurrent TCP connections allowed.mrd.target-pending-bytes: The target threshold for pending bytes to trigger autoscaling.mrd.target-pending-ranges: The target threshold for pending ranges to trigger autoscaling.This PR is the first of a multi-part series splitting the overall connection pool autoscaling implementation. It is purely declarative and safe; because these fields are not yet wired up in the downloader wrapper or instance code, they have zero functional runtime impact on existing codepaths.
Link to the issue in case of a bug fix.
b/504489809
Testing details
go build ./...and basic layout validation).cfgpackage unit tests pass successfully, covering the new connection and autoscaling configuration boundaries and combinations.Any backward incompatible change? If so, please explain.
N/A