refactor(mounting): remove obsolete list-access-check CLI flag and logic

[meet2mky]

Description

Cleanup the old code for disable list access check and flag. Flag usage is zero for the last 30 days in GKE: https://screenshot.googleplex.com/AueqegeHAJMeQZF

Link to the issue in case of a bug fix.

b/471129209

Testing details

1. Manual - Yes
2. Unit tests - Yes
3. Integration tests - NA

Any backward incompatible change? If so, please explain.

NONE

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.64%. Comparing base (efc456f) to head (456a643).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #4722       +/-   ##
===========================================
+ Coverage        0   83.64%   +83.64%     
===========================================
  Files           0      165      +165     
  Lines           0    20643    +20643     
===========================================
+ Hits            0    17266    +17266     
- Misses          0     2731     +2731     
- Partials        0      646      +646     

Flag	Coverage Δ
unittests	83.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request performs a cleanup of the codebase by removing the 'disable-list-access-check' flag and its corresponding implementation. The change simplifies the bucket setup process during mounting by relying on the StorageLayout API for bucket validation, rendering the previous list-based access check obsolete. Corresponding tests and configuration files have been updated to maintain consistency.

Highlights

• Removal of obsolete flag: Removed the 'disable-list-access-check' CLI flag and its associated configuration logic as it is no longer required.
• Code cleanup: Cleaned up the bucket manager initialization logic by removing the redundant ListObject API check, relying instead on the StorageLayout API.
• Test suite updates: Updated unit tests to reflect the removal of the flag and adjusted mock expectations for bucket validation to align with the new flow.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request removes the DisableListAccessCheck configuration and the associated ListObjects API check during the mount operation, transitioning the access check logic to rely on GetStorageLayout. The changes include the removal of the relevant struct fields, CLI flags, and configuration parameters across the codebase, along with corresponding test updates. Review feedback identifies potential nil pointer dereferences in the updated unit tests where bucket.Syncer is accessed after a failed SetUpBucket call; it is recommended to assert that the bucket itself is nil instead.

[github-actions]

Hi @raj-prince, @abhishek10004, @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

[github-actions]

Hi @raj-prince, @abhishek10004, @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!

[github-actions]

Hi @raj-prince, @abhishek10004, @vadlakondaswetha, your feedback is needed to move this pull request forward. This automated reminder was triggered because there has been no activity for over 24 hours. Please provide your input when you have a moment. Thank you!