Skip to content

Bugfix unicode compatibility #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wradstok wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Bugfix unicode compatibility #30

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5a8aa66
Bugfix unicode compatibility
wradstok Jul 20, 2020
20c37cd
Fix indentation mistake
wradstok Jul 20, 2020
325bee0
Fix root cause of trailing space key issue
wradstok Jul 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix indentation mistake
  • Loading branch information
@wradstok
wradstok committed Jul 20, 2020
commit 20c37cdb134642a51e582386fb624239bbc4a180
2 changes: 1 addition & 1 deletion codes/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ def read_triple(file_path, entity2id, relation2id):
triples = []
with open(file_path) as fin:
for line in fin:
h, r, t = map(lambda x: x.strip(), unicodedata.normalize('NFKC', line).split('\t'))
h, r, t = map(lambda x: x.strip(), unicodedata.normalize('NFKC', line).split('\t'))
Copy link
Copy Markdown

@cthoyt cthoyt Jul 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

str.strip could be a shorter replacement for lambda x: x.strip()

Copy link
Copy Markdown
Author

@wradstok wradstok Jul 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, didn't realize this was possible.

triples.append((entity2id[h], relation2id[r], entity2id[t]))
return triples

Expand Down