Derive shortened release role names#86
Merged
Merged
Conversation
kans
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The reusable connector release workflow assumes artifact and ECR push roles whose names are derived from repository names. Long connector repository names can exceed the AWS IAM 64-character role-name limit, so the workflow needs to derive the same shortened names that ops creates.
What this changes
Adds a checked-in helper script for deterministic IAM role-name derivation and uses it before AWS role assumption in the standard release jobs. Existing short names are unchanged; over-limit names keep the first 55 characters plus an 8-character SHA-256 prefix.
Cross-review follow-up added expanded golden vectors and sets
LC_ALL=Cso bash length and slicing semantics match the Go implementations byte-for-byte.Validation
make testyq "." .github/workflows/release.yaml >/dev/nullgit diff --checkMerge order
Merge with
ductone/ops#7767andConductorOne/github-axiomatic-workflows#1before relying on shortened names for long connector repositories.