fix: remaining issues with subscriber client#43
Merged
Conversation
Fix make_subscriber to defer GRPC client creation. Fix retrying_connection to not let __aenter__ return until successful initialization or permanent failure.
9b354e5 to
1123bcd
Compare
anguillanneuf
approved these changes
Oct 12, 2020
Contributor
anguillanneuf
left a comment
There was a problem hiding this comment.
Tested with a sample and it worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix make_subscriber to defer GRPC client creation.
Fix retrying_connection to not let aenter return until successful initialization or permanent failure.