fix: Increment ack generation id#203
Merged
Merged
Conversation
Also handle duplicate acks.
dpcollins-google
approved these changes
Aug 3, 2021
dpcollins-google
suggested changes
Aug 3, 2021
Contributor
dpcollins-google
left a comment
There was a problem hiding this comment.
ignoring duplicate acks is not correct. The cloud Pub/Sub Library fails on duplicate acks
dpcollins-google
approved these changes
Aug 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increment the ack generation id correctly.
++does not increment in Python.