Skip to content

feat: Support seek subscription in AdminClient#176

Merged
tmdiep merged 10 commits into
googleapis:masterfrom
tmdiep:seek_subscription
Aug 10, 2021
Merged

feat: Support seek subscription in AdminClient#176
tmdiep merged 10 commits into
googleapis:masterfrom
tmdiep:seek_subscription

Conversation

@tmdiep
Copy link
Copy Markdown
Contributor

@tmdiep tmdiep commented Jul 2, 2021

Seek subscription performs an out-of-band seek for a subscription to a specified target, which may be a backlog location, publish timestamp or event timestamp.

@tmdiep tmdiep added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 2, 2021
@tmdiep tmdiep requested review from a team July 2, 2021 04:35
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Jul 2, 2021

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2021
@product-auto-label product-auto-label Bot added the api: pubsublite Issues related to the googleapis/python-pubsublite API. label Jul 2, 2021
@tmdiep
Copy link
Copy Markdown
Contributor Author

tmdiep commented Jul 2, 2021

Note: this feature is pre-release. The "do not merge" label will be removed once publicly available.

@tmdiep tmdiep force-pushed the seek_subscription branch from 8587b10 to def076e Compare July 2, 2021 05:28
@tmdiep tmdiep force-pushed the seek_subscription branch from dfead22 to fe18203 Compare July 7, 2021 05:15
@tmdiep tmdiep requested a review from dpcollins-google July 29, 2021 00:29
Comment thread samples/snippets/seek_lite_subscription_example.py Outdated
Comment thread google/cloud/pubsublite/internal/wire/admin_client_impl.py Outdated
Copy link
Copy Markdown
Contributor

@dpcollins-google dpcollins-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming fixes are made

@tmdiep tmdiep added kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Aug 8, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Aug 8, 2021
@tmdiep tmdiep merged commit fc648ae into googleapis:master Aug 10, 2021
@tmdiep tmdiep deleted the seek_subscription branch August 10, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/python-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants