fix: Centralize alarm executor creation for Pub/Sub Lite#565
Merged
Conversation
Also prevent creation of per-object thread pools which are largely unused and may prevent shutdown if not using daemon threads.
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
============================================
+ Coverage 72.63% 72.77% +0.14%
- Complexity 861 868 +7
============================================
Files 156 157 +1
Lines 4488 4493 +5
Branches 211 210 -1
============================================
+ Hits 3260 3270 +10
+ Misses 1107 1103 -4
+ Partials 121 120 -1
Continue to review full report at Codecov.
|
anguillanneuf
approved these changes
Mar 30, 2021
Contributor
anguillanneuf
left a comment
There was a problem hiding this comment.
I tested the fix with a simple example to write two messages to a Lite topic. Shutdown worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also prevent creation of per-object thread pools which are largely unused and may prevent shutdown if not using daemon threads.