feat: Change message id on PubsubMessages to be an encoded MessageMetadata and rename PublishMetadata to MessageMetadata#482
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #482 +/- ##
============================================
+ Coverage 75.31% 75.38% +0.06%
- Complexity 758 760 +2
============================================
Files 129 129
Lines 3865 3875 +10
Branches 174 174
============================================
+ Hits 2911 2921 +10
Misses 850 850
Partials 104 104
Continue to review full report at Codecov.
|
manuelmenzella-google
suggested changes
Feb 3, 2021
…adata PublishMetadata is both the partition and offset, and is an ID suitable for deduplication. FIXES: #471
6fd6163 to
fa11c62
Compare
manuelmenzella-google
approved these changes
Feb 3, 2021
anguillanneuf
approved these changes
Feb 4, 2021
Contributor
anguillanneuf
left a comment
There was a problem hiding this comment.
LGTM.
You don't really need to change README.md as any change in .readme-partials.yaml will trigger an update in README.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PublishMetadata is both the partition and offset, and is an ID suitable for deduplication.
Fixes #471