fix: Deadlock in RetryingConnectionImpl when tearing down a connection#406
Merged
Conversation
Also use a shared executor for all GRPC clients to reduce total threadcount and fix errors when tearing down executors used by GRPC connections. Also add logging to RetryingConnectionImpl Also ensure all calls out from RetryingConnectionImpl cannot leak exceptions.
manuelmenzella-google
approved these changes
Dec 8, 2020
Codecov Report
@@ Coverage Diff @@
## master #406 +/- ##
============================================
- Coverage 71.70% 71.28% -0.43%
+ Complexity 814 810 -4
============================================
Files 156 156
Lines 4404 4377 -27
Branches 219 221 +2
============================================
- Hits 3158 3120 -38
- Misses 1126 1137 +11
Partials 120 120
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also use a shared executor for all GRPC clients to reduce total threadcount and fix errors when tearing down executors used by GRPC connections.
Also add logging to RetryingConnectionImpl
Also ensure all calls out from RetryingConnectionImpl cannot leak exceptions.
Also ensure all streams have heartbeating enabled.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️