Skip to content

fix: Remove extra logic to convert to project numbers now that this is handled in the backend#397

Merged
dpcollins-google merged 3 commits into
masterfrom
remove-project-logic
Dec 4, 2020
Merged

fix: Remove extra logic to convert to project numbers now that this is handled in the backend#397
dpcollins-google merged 3 commits into
masterfrom
remove-project-logic

Conversation

@dpcollins-google
Copy link
Copy Markdown
Contributor

No description provided.

@dpcollins-google dpcollins-google requested review from a team December 3, 2020 21:36
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2020
@product-auto-label product-auto-label Bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Dec 3, 2020
@anguillanneuf
Copy link
Copy Markdown
Contributor

8001: com.google.cloud.pubsublite.ProjectLookupUtils: Class com.google.cloud.pubsublite.ProjectLookupUtils removed

Need to add this one to the ignore file.

@dpcollins-google
Copy link
Copy Markdown
Contributor Author

Fixed.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 4, 2020

Codecov Report

Merging #397 (c9fd8fa) into master (74a8504) will decrease coverage by 1.17%.
The diff coverage is 84.61%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #397      +/-   ##
============================================
- Coverage     72.83%   71.66%   -1.18%     
- Complexity      801      809       +8     
============================================
  Files           150      155       +5     
  Lines          4300     4344      +44     
  Branches        215      219       +4     
============================================
- Hits           3132     3113      -19     
- Misses         1050     1112      +62     
- Partials        118      119       +1     
Impacted Files Coverage Δ Complexity Δ
...loud/pubsublite/internal/wire/RoutingMetadata.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...google/cloud/pubsublite/beam/PublisherOptions.java 25.00% <0.00%> (+1.47%) 4.00 <0.00> (ø)
...loud/pubsublite/cloudpubsub/PublisherSettings.java 100.00% <100.00%> (ø) 7.00 <0.00> (ø)
...oud/pubsublite/cloudpubsub/SubscriberSettings.java 89.36% <100.00%> (-0.23%) 12.00 <0.00> (ø)
...gle/cloud/pubsublite/internal/AdminClientImpl.java 100.00% <100.00%> (ø) 18.00 <2.00> (ø)
...loud/pubsublite/internal/TopicStatsClientImpl.java 100.00% <100.00%> (ø) 3.00 <0.00> (ø)
...loud/pubsublite/internal/wire/AssignerBuilder.java 65.38% <100.00%> (-1.29%) 3.00 <0.00> (ø)
...oud/pubsublite/internal/wire/CommitterBuilder.java 52.63% <100.00%> (-2.37%) 2.00 <0.00> (ø)
...oud/pubsublite/internal/wire/PublisherBuilder.java 62.26% <100.00%> (ø) 3.00 <0.00> (ø)
...ud/pubsublite/internal/wire/SubscriberBuilder.java 40.74% <100.00%> (-2.12%) 2.00 <0.00> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74a8504...c9fd8fa. Read the comment docs.

@dpcollins-google dpcollins-google merged commit 14e5ab4 into master Dec 4, 2020
@dpcollins-google dpcollins-google deleted the remove-project-logic branch December 4, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants