feat: All changes required to change library to use ApiException and gapic internals#295
Merged
Conversation
aa951a8 to
8d2e164
Compare
manuelmenzella-google
approved these changes
Oct 20, 2020
anguillanneuf
suggested changes
Oct 24, 2020
Contributor
There was a problem hiding this comment.
Thanks for making this PR. I didn't review any of the tests. Here are some issues I found:
- This comment about setting stub on the publisher needs an update:
- I'm not sure if you intended
google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/testing/UnitTestExamples.javato be there. - Sporadic class descriptions in
google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/internal/wire/. - Changes in
pubsublite-beam-io/andpubsublite-kafka-shim/should be their own PRs. - Changes to
grpc-google-cloud-pubsublite-v1/should come from synthtool pulling from the source. - Update samples in a later PR.
- Also please resolve the conflicts with main.
I haven't tried the code to see how they impact samples myself. I can do that next week.
7b6bd05 to
beda6df
Compare
Contributor
Author
Replies to each point below.
|
anguillanneuf
approved these changes
Oct 26, 2020
Contributor
There was a problem hiding this comment.
- It's in the public documentation, either we add more documentation there, or we choose to hide it. Can be in a later PR.
- Ok. Make sure to make a new release soon after this PR is merged then.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This converts the internals of the client library to use GAPIC generated clients, as well as the api surface to raise ApiException as opposed to grpc StatusException.
fixes #180
fixes #148
This does not throw RESOURCE_EXHAUSTED at high partition counts with the following code when removing RESOURCE_EXHAUSTED from the list of retryable errors: