Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-120258: Correct MIME type for .ass files #120252

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

rcombs
Copy link

@rcombs rcombs commented Jun 8, 2024

Advanced SubStation is a common subtitle format, and the ".ass" extension is not commonly used for AAC audio files.

@rcombs rcombs requested a review from a team as a code owner June 8, 2024 02:21
Copy link

cpython-cla-bot bot commented Jun 8, 2024

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Jun 8, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@aisk
Copy link
Member

aisk commented Jun 8, 2024

Hi, according to the devguide, only trivial changes like fixing a typo don't require a GitHub issue first, so I think this change requires a related issue.

rcombs and others added 2 commits June 8, 2024 00:31
Advanced SubStation is a common subtitle format, and the ".ass" extension is not commonly used for AAC audio files.
@rcombs rcombs changed the title Correct MIME type for .ass files gh-120252: Correct MIME type for .ass files Jun 8, 2024
@rcombs rcombs changed the title gh-120252: Correct MIME type for .ass files gh-120258: Correct MIME type for .ass files Jun 8, 2024
@rcombs
Copy link
Author

rcombs commented Jun 8, 2024

I'd thought of this as sufficiently trivial, but sure, done.

@aisk
Copy link
Member

aisk commented Jun 8, 2024

I did some research and found that although .ass subtitle files are more common these days, .ass is also an IANA registered file type for the audio type: https://www.iana.org/assignments/media-types/audio/aac. So, I think we can't change it directly.

Moreover, the mimetypes package not only uses this predefined map in the source code, it also uses the system's mimetype database to get the associated mimetypes from the file extension, and Debian uses data from IANA: https://salsa.debian.org/debian/media-types/-/blob/master/mime.types#L1681

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants