Closed
Conversation
Regex used ((PyGetSetDef|PyMemberDef|PyMethodDef|PyStructSequence_Field|PyStructSequence_Desc) .* = \{
[\s\S]*
.*?"(?<!\))\}|\{Py_tp_doc, ")
Gobot1234
requested review from
abalkin,
corona10,
lysnikolaou,
markshannon,
pablogsal,
pganssle and
rhettinger
as code owners
Contributor
Author
|
@sobolevn would you mind reviewing this? |
sobolevn
reviewed
Sep 29, 2023
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
The diff was rather hard to review, since there are so many changed files.
Plus, this generates quite a lot of blame changes for important pieces of code.
(This is just a statement for others to keep in mind, I still think that this is a proper bug fix).
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #109393 I also chose to add this to
StructSequences because they seem to be doing a similiar thingRegex used
((PyGetSetDef|PyMemberDef|PyMethodDef|PyStructSequence_Field|PyStructSequence_Desc) .* = \{ [\s\S]* .*?"(?<!\))\}|\{Py_tp_doc, ")