New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align Expected and Actual titles in assert_has_calls/assert_called_with for greater readability #111019
Labels
Comments
morisja
added a commit
to morisja/cpython
that referenced
this issue
Oct 18, 2023
Align expected and actual titles in output from assert_has_calls/assert_called_with for greater readability
morisja
added a commit
to morisja/cpython
that referenced
this issue
Oct 18, 2023
Align expected and actual titles in output from assert_has_calls/assert_called_with for greater readability
cjw296
pushed a commit
that referenced
this issue
Oct 18, 2023
Align expected and actual titles in output from assert_has_calls/assert_called_with for greater readability
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Oct 18, 2023
…honGH-111020) Align expected and actual titles in output from assert_has_calls/assert_called_with for greater readability (cherry picked from commit 77dbd95) Co-authored-by: James <morisja@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Oct 18, 2023
…honGH-111020) Align expected and actual titles in output from assert_has_calls/assert_called_with for greater readability (cherry picked from commit 77dbd95) Co-authored-by: James <morisja@gmail.com>
|
An alternative would have been to click 'Expected' to 'Actual', but verb-adjective is a bit jarring. Indent is fine and alignment will help. |
danigm
added a commit
to danigm/pytest-mock
that referenced
this issue
Dec 20, 2023
nicoddemus
pushed a commit
to pytest-dev/pytest-mock
that referenced
this issue
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature or enhancement
Proposal:
The current output for
assert_called_withandassert_has_callshas different spacing making visual identification of simple issues challenging.Example:
I propose whitespace is added preceding
Actual:to align as follows:I chose preceding to minimize any potential parsing (e.g
Actual :would make two fields if split by whitespace)Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
I found similar, but not exact discussion here
#79681
Linked PRs
The text was updated successfully, but these errors were encountered: