bpo-43501: _header_value_parser: handle DOT in DisplayName#24874
bpo-43501: _header_value_parser: handle DOT in DisplayName#24874elenril wants to merge 1 commit intopython:mainfrom
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Ping. Still waiting for review. |
|
The question is, should this be parsed or should it raise a more informative error, e.g. something like "name should be quoted"? Can you find the relevant RFC rule? I tested it and if the name is quoted, it's parsed successfully: |
|
Honestly I see little point in spending effort on finding whether this might or might not be compatible with some obscure obsolete syntax or not. According to the comments in the source this already adds an |
1788507 to
4803262
Compare
|
Ping. |
A DisplayName is merely a wrapper around a Phrase. However, its property methods fail to deal with the fact that a phrase may contain DOT terminals in addition to words. Fixes processing headers, such as: From: foobar.<baz@spam>
4803262 to
94eaac6
Compare
|
Ping. |
https://bugs.python.org/issue43501