Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift: Closure Capture Flow #12736

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Swift: Closure Capture Flow #12736

wants to merge 2 commits into from
+2,774 −63

Conversation

d10c
Copy link
Contributor

@d10c d10c commented Mar 31, 2023

  • Swift: refactor the public API wrt captures
  • Swift: introduce CapturedDecls as CFG nodes
  • Swift: more CapturedDecl test cases

@d10c d10c requested a review from a team as a code owner March 31, 2023 15:28
@github-actions github-actions bot added the Swift label Mar 31, 2023
@d10c d10c mentioned this pull request Mar 31, 2023
Closed
15 tasks
MathiasVP
MathiasVP reviewed Mar 31, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments, but otherwise this LGTM

swift/ql/lib/codeql/swift/elements/decl/CapturedDecl.qll Show resolved Hide resolved
swift/ql/lib/codeql/swift/elements/AstNode.qll Show resolved Hide resolved
@d10c d10c marked this pull request as draft April 3, 2023 09:58
MathiasVP
MathiasVP previously approved these changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as soon as:

  • We have accepted the test changes (I think a line-number changed?)
  • We have a sucesfull DCA run

d10c added 2 commits April 4, 2023 12:03
@d10c
Swift: refactor the public API wrt captures
7823353 
This exposes capture- and access-related methods under different names.
@d10c
Swift: more CapturedDecl test cases
4e113ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Swift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d10c @MathiasVP