Skip to content

Added one comment (first time contributor)#8106

Closed
AyuubHassan wants to merge 1 commit intoTheAlgorithms:masterfrom
AyuubHassan:ayuub
Closed

Added one comment (first time contributor)#8106
AyuubHassan wants to merge 1 commit intoTheAlgorithms:masterfrom
AyuubHassan:ayuub

Conversation

@AyuubHassan
Copy link

@AyuubHassan AyuubHassan commented Jan 29, 2023

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@algorithms-keeper algorithms-keeper bot added enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Jan 29, 2023
@AyuubHassan
Copy link
Author

Please merge

@AyuubHassan AyuubHassan marked this pull request as draft January 29, 2023 15:22
@AyuubHassan AyuubHassan marked this pull request as ready for review January 29, 2023 15:22
@tianyizheng02
Copy link
Contributor

What does this add to the pyproject.toml file?

Copy link
Contributor

@CaedenPH CaedenPH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very trivial and quite unnecessary - Perhaps you could add comments to places that would confuse people

@dhruvmanila dhruvmanila added invalid and removed enhancement This PR modified some existing files awaiting reviews This PR is ready to be reviewed labels Apr 1, 2023
@dhruvmanila dhruvmanila closed this Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants