Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update container hook environment variable name #24028

Closed
wants to merge 4 commits into from

Conversation

david-smith-cko
Copy link

@david-smith-cko david-smith-cko commented Feb 20, 2023

Why:

The environment variable name used for specifying the path to a container hook script was incorrect. This was cross referenced against the action runner's source code: https://github.com/actions/runner/blob/main/src/Runner.Common/Constants.cs#L208

What's being changed (if available, include any code snippets, screenshots, or gifs):

The name of the environment variable has been updated in the docs.

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

The environment variable name used for specifying the path to a container hook script was incorrect. This was cross referenced against the action runner's source code: https://github.com/actions/runner/blob/main/src/Runner.Common/Constants.cs#L208
@welcome
Copy link

welcome bot commented Feb 20, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Feb 20, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/hosting-your-own-runners/customizing-the-containers-used-by-jobs.md fpt
ghec
fpt
ghec

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@david-smith-cko Thanks so much for opening a PR! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team labels Feb 21, 2023
@vgrl vgrl added the small fix label May 29, 2023
@SiaraMist
Copy link
Contributor

Hey @david-smith-cko, thank you so much for making this fix and for your patience as we work through our backlog. 💛 It looks like someone else spotted this and updated it too, so I'm going to go ahead and close this PR. We appreciate your help improving the docs!

@SiaraMist SiaraMist closed this Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants