Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link users to Multiline strings section #23027

Merged
merged 3 commits into from Mar 30, 2023
Merged

Conversation

dawei-wang
Copy link
Contributor

@dawei-wang dawei-wang commented Jan 5, 2023

Fixes #21529

Why:

Closes #21529

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team. label Jan 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/using-workflows/workflow-commands-for-github-actions.md fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae
fpt
ghec
ghes@ 3.8 3.7 3.6 3.5 3.4
ghae

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@cmwilson21
Copy link
Contributor

@dawei-wang Thanks for submitting a PR with this fix! I'll get this triaged for review ⚡

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review and removed triage Do not begin working on this issue until triaged by the team. labels Jan 6, 2023
@mchammer01 mchammer01 self-requested a review February 7, 2023 15:32
mchammer01

This comment was marked as duplicate.

Copy link
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dawei-wang 👋🏻 - thanks for your contribution, it LGTM ✨
I made a couple of minor suggestions that I am going to commit.
In this comment, @skedwards88 suggested we included an example.
What do you think? Are you happy to add the example in your PR?

@mchammer01
Copy link
Contributor

Closing this for 5 mins or so as the Deploy Preview Environment test seems to be unhappy.

@mchammer01 mchammer01 closed this Feb 7, 2023
@mchammer01 mchammer01 reopened this Feb 7, 2023
@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team. label Feb 7, 2023
@cmwilson21 cmwilson21 removed the triage Do not begin working on this issue until triaged by the team. label Feb 7, 2023
@cmwilson21
Copy link
Contributor

@dawei-wang 👋 - Just checking in. Have you had a chance to think about adding an example per the request here?

@cmwilson21 cmwilson21 added the more-information-needed More information is needed to complete review. label Feb 21, 2023
@cmwilson21
Copy link
Contributor

cmwilson21 commented Mar 30, 2023

Going to go ahead and merge the content change and a contributor will add an example later

@cmwilson21 cmwilson21 added ready to merge This pull request is ready to merge and removed more-information-needed More information is needed to complete review. labels Mar 30, 2023
@docubot docubot added this to Triage in Docs open source board Mar 30, 2023
@cmwilson21 cmwilson21 merged commit 7cd4110 into github:main Mar 30, 2023
21 checks passed
Docs open source board automation moved this from Triage to Done Mar 30, 2023
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@dawei-wang dawei-wang deleted the patch-2 branch March 30, 2023 17:03
@1oglop1
Copy link

1oglop1 commented Oct 25, 2023

@cmwilson21 why is this merged? I've just spent several hours trying to get it working without success and it is absolutely frustrating

steps:
    - id: submit
      name: submit deploy
      shell: bash
      env:
        GITHUB_TOKEN: "${{ inputs.gh_token }}"
        PULUMI_STACK: ${{inputs.app_environment}}
        APP: ${{inputs.app_name || inputs.app_environment }}
        REF: ${{ inputs.branch || github.ref }}
      run: |
        response=$(curl --silent --show-error --fail \
          -X POST "https://api.github.com/repos/$GITHUB_REPOSITORY/deployments" \
          -H "Authorization: token $GITHUB_TOKEN" \
          -H "Content-Type: text/json; charset=utf-8" \
          -d @- <<EOF
        {
          "ref":"$REF",
          "description": "autodeploy",
          "required_contexts": [],
          "auto_merge": false,
          "environment": "$APPENV",
          "payload": {
            "environment": "$APP",
            "pulumi_stack": "$PULUMI_STACK",
            "app": "$APP"
          }
        }
        EOF
        )

        echo "response<<EOF" >> $GITHUB_OUTPUT
        echo "$response" >> $GITHUB_OUTPUT
        echo "EOF" >> $GITHUB_OUTPUT

with error

echo {
/home/runner/work/_temp/343c5f31-a8d6-4aba-92cf-92b61da19f67.sh: line 2: url:: command not found
{
Error: Process completed with exit code 127.

@cmwilson21
Copy link
Contributor

👋 @1oglop1 - This PR only merged a link referring to the multiline documentation. No examples or directions were changed in this PR. For more reference on this, you can check out the original issue. If that doesn't help, please reach out to the Actions community in our Community Discussions for support! 💛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge waiting for review Issue/PR is waiting for a writer's review
Development

Successfully merging this pull request may close these issues.

Clarify how multiline output values can be set via GITHUB_OUTPUT
4 participants