Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mac/Extras.install.py，Can not filter osx .DS_Store file #98940

Closed
zhangbo2012 opened this issue Nov 1, 2022 · 1 comment
Closed

Mac/Extras.install.py，Can not filter osx .DS_Store file #98940

zhangbo2012 opened this issue Nov 1, 2022 · 1 comment
Labels
type-bug An unexpected behavior, bug, or error

Comments

@zhangbo2012
Copy link
Contributor

zhangbo2012 commented Nov 1, 2022 •
edited by bedevere-bot

Mac/Extras.install.py，Can not filter osx .DS_store file

Mac/Extras.install.py，Can not filter osx DS_store file

As

if name == '.DS_store': return 0

But in OSX, Real File Name is .DS_Store, like this

(venv) zhangbo@zhangbodeMacBook-Pro a2 % ll -a
total 16
drwxr-xr-x  4 zhangbo  staff   128 Oct 22 17:34 .
drwxr-xr-x  8 zhangbo  staff   256 Oct 22 17:18 ..
-rw-r--r--@ 1 zhangbo  staff  6148 Oct 22 17:17 .DS_Store
drwxr-xr-x  3 zhangbo  staff    96 Oct 22 17:23 123

So we need update .DS_store to .DS_Store

Your environment

macOS 11.1
@zhangbo2012 zhangbo2012 added the type-bug An unexpected behavior, bug, or error label Nov 1, 2022
@zhangbo2012 zhangbo2012 mentioned this issue Nov 1, 2022
Merged
ronaldoussoren pushed a commit that referenced this issue Nov 16, 2022
@zhangbo2012 @sobolevn
gh-98940: Fix Mac/Extras.install.py File filter bug (#98943)
ea88d34 
Slightly simplify the script and fix a case issue in the name of ``.DS_Store`` files.

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 16, 2022
@zhangbo2012 @sobolevn @miss-islington
pythongh-98940: Fix Mac/Extras.install.py File filter bug (pythonGH-9…
148369e 
…8943)

Slightly simplify the script and fix a case issue in the name of ``.DS_Store`` files.

(cherry picked from commit ea88d34)

Co-authored-by: zhangbo <zhangbo2012@outlook.com>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@bedevere-bot bedevere-bot mentioned this issue Nov 16, 2022
Merged
@ronaldoussoren
Copy link
Contributor

ronaldoussoren commented Nov 16, 2022 •
edited

I've merged the PR into main and 3.11.

miss-islington added a commit that referenced this issue Nov 16, 2022
@miss-islington @zhangbo2012 @sobolevn
gh-98940: Fix Mac/Extras.install.py File filter bug (GH-98943)
0a208d5 
Slightly simplify the script and fix a case issue in the name of ``.DS_Store`` files.

(cherry picked from commit ea88d34)

Co-authored-by: zhangbo <zhangbo2012@outlook.com>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ronaldoussoren @zhangbo2012