gh-42127 Expand child process console opening comments. #96987
Conversation
Doc/library/subprocess.rst
Outdated
| the child's file handles will be inherited from the parent for console | ||
| applications, if the child can connect to the console. Otherwise it will | ||
| allocate a new console. For non-console applications, the window manager | ||
| and graphical shell will determine behavior. Additionally, *stderr* can be |
There was a problem hiding this comment.
I think it'd be better to avoid changing the original sentence structure starting from 'Additionally' so it'll a bit easier to review the diffs and changes, since the sentences are identical from that point onward.
There was a problem hiding this comment.
I understand the point, start a new line at "Additionally". There are two instances of this dcoument section, lines 272 and 492 in the existing code. For 272, it would be easy to insert as you noted, but the "Additionally" on line 492 is not at a line break. What should be done about that one?
There was a problem hiding this comment.
Same, try to minimize changes to untouched lines. It is fine if one line is a bit too long, or if you move its end to a new line that’s a bit short. It doesn’t change the output but keeps git log / annotate / etc useful 🙂
There was a problem hiding this comment.
Changes made, did I understand and implement correctly?
Thanks!
There was a problem hiding this comment.
Not fully, but I completed the change!
…e paragraph group
|
Ah, I see what you did. I had avoided that, on the assumption that it would still impact the diffs. Was I incorrect? |
|
Oh were you worried about adding more changes to the files? For Python pull requests, we don’t care if it takes multiple commits to get to a good result, the pull request is «squash merged» meaning all changes become one commit added to the main branch. So here I didn’t mind changing more lines again in an intermediary commit, I only cared about the total diff. Hope this explains it! |
|
Sorry, I don't see a way to connect a different source branch to this PR. I'll close it again and start anew. The new PR is #97614 |
This expands the child process console opening in Doc/library/subprocess.rst. This PR is compatible with branch 3.11, but not with branch 3.10.