Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-95994: Clarify escaped newlines. #96066

Merged
merged 3 commits into from Aug 26, 2022
Merged

gh-95994: Clarify escaped newlines. #96066

merged 3 commits into from Aug 26, 2022

Conversation

ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented Aug 18, 2022 •
edited by bedevere-bot

@ezio-melotti ezio-melotti self-assigned this Aug 18, 2022
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Aug 18, 2022
@ezio-melotti ezio-melotti requested a review from CAM-Gerlach Aug 19, 2022
CAM-Gerlach
CAM-Gerlach reviewed Aug 20, 2022
View changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Good change overall;, thanks two comments.

Sidenote: Presumably out of scope here, but using actual footnotes for these would not only be more convenient for readers and more semantically meaningful, but also (with autonumbered named footnotes) avoid extra work, diff noise and bugs due to misaligned footnotes.

Doc/reference/lexical_analysis.rst Outdated Show resolved Hide resolved
Doc/reference/lexical_analysis.rst Outdated Show resolved Hide resolved
ezio-melotti and others added 2 commits Aug 21, 2022
@ezio-melotti @CAM-Gerlach
Rephrase ambiguous sentence.
ec8b6ae 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@ezio-melotti @CAM-Gerlach
Use <newline> in escape sequences table.
39fcfc1 
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
@ezio-melotti ezio-melotti merged commit c3d591f into python:main Aug 26, 2022
14 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Aug 26, 2022

Thanks @ezio-melotti for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@ezio-melotti ezio-melotti deleted the escaped-newline branch Aug 26, 2022
@bedevere-bot
Copy link

bedevere-bot commented Aug 26, 2022

GH-96321 is a backport of this pull request to the 3.11 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Aug 26, 2022

Sorry, @ezio-melotti, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c3d591fd0699605c8253beda2372114052a7bdba 3.10

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 26, 2022
@ezio-melotti @miss-islington
pythongh-95994: Clarify escaped newlines. (pythonGH-96066)
2217dc0 
* pythongh-95994: clarify escaped newlines.

* Rephrase ambiguous sentence.

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

* Use `<newline>` in escape sequences table.

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit c3d591f)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Aug 26, 2022

Thanks @ezio-melotti for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Aug 26, 2022

Sorry @ezio-melotti, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c3d591fd0699605c8253beda2372114052a7bdba 3.10

miss-islington added a commit that referenced this pull request Aug 26, 2022
@miss-islington @ezio-melotti
gh-95994: Clarify escaped newlines. (GH-96066)
f0469c7 
* gh-95994: clarify escaped newlines.

* Rephrase ambiguous sentence.

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

* Use `<newline>` in escape sequences table.

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
(cherry picked from commit c3d591f)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Aug 28, 2022

GH-96360 is a backport of this pull request to the 3.10 branch.

ezio-melotti added a commit to ezio-melotti/cpython that referenced this pull request Aug 28, 2022
@ezio-melotti
[3.10] pythongh-95994: Clarify escaped newlines. (pythonGH-96066)
6659b83 
* pythongh-95994: clarify escaped newlines.

* Rephrase ambiguous sentence.

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

* Use `<newline>` in escape sequences table.

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>.
(cherry picked from commit c3d591f)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti added a commit that referenced this pull request Aug 28, 2022
@ezio-melotti
[3.10] gh-95994: Clarify escaped newlines. (GH-96066) (#96360)
f51c232 
* gh-95994: clarify escaped newlines.

* Rephrase ambiguous sentence.

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

* Use `<newline>` in escape sequences table.

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>

Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>.
(cherry picked from commit c3d591f)

Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
@ezio-melotti ezio-melotti mentioned this pull request Aug 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach

Assignees

@ezio-melotti ezio-melotti

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ezio-melotti @miss-islington @bedevere-bot @CAM-Gerlach