Skip to content

gh-94264: fnv uses LLVM __builtin_memcpy_inline if available.#94263

Closed
devnexen wants to merge 1 commit intopython:mainfrom
devnexen:py_hash__builtin_memcpy_inline
Closed

gh-94264: fnv uses LLVM __builtin_memcpy_inline if available.#94263
devnexen wants to merge 1 commit intopython:mainfrom
devnexen:py_hash__builtin_memcpy_inline

Conversation

@devnexen
Copy link
Contributor

@devnexen devnexen commented Jun 25, 2022

guarantees to not generating extra calls unlike __builtin_memcpy
but only work with compile time sizes.

guarantees to not generating extra calls unlike __builtin_memcpy
but only work with compile time sizes.
@devnexen devnexen requested a review from tiran as a code owner June 25, 2022 11:07
@devnexen devnexen changed the title fnv uses LLVM __builtin_memcpy_inline if available. gh-94264: fnv uses LLVM __builtin_memcpy_inline if available. Jun 25, 2022
@methane
Copy link
Member

methane commented Jul 16, 2023

I don't think this change is needed.

  • Even not guaranteed, clang and gcc will optimize constant size memcpy
  • fnv is not the standard hash function

@methane methane closed this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants