gh-94165: Prevent PY_CHECK_SQLITE_FUNC from accumulating linker options #94198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
changed the title
|
Similar to the curses macro. |
|
Darn, there are some Ubuntu issues. |
tiran
reviewed
Jun 24, 2022
| [have_sqlite3_load_extension=yes], | ||
| [have_sqlite3_load_extension=no] | ||
| ) | ||
| AC_CHECK_LIB([sqlite3], [sqlite3_serialize], [ | ||
| PY_CHECK_SQLITE_FUNC([sqlite3_serialize], [ |
There was a problem hiding this comment.
The third argument to PY_CHECK_SQLITE_FUNC([sqlite3_serialize], ...) is blank. Wouldn't this set have_supported_sqlite3=no if sqlite is missing the feature?
There was a problem hiding this comment.
I added a dummy value. Alternatively we could for example add a fourth argument (required=true|false) to PY_CHECK_SQLITE_FUNC.
There was a problem hiding this comment.
I'll have to revisit this later today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Fixes gh-94165