Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./configure eventfd support does not also check for existence of flags #93899

Closed
gha-xena opened this issue Jun 16, 2022 · 2 comments
Closed

./configure eventfd support does not also check for existence of flags #93899

gha-xena opened this issue Jun 16, 2022 · 2 comments
Assignees
@kumaraditya303
Labels
3.10 bug and security fixes 3.11 bug and security fixes 3.12 new features, bug and security fixes type-bug An unexpected behavior, bug, or error

Comments

@gha-xena
Copy link

Bug report

The configure script currently checks if sys/eventfd.h exists, and then later uses that in posixmodule.c here: https://github.com/python/cpython/blob/main/Modules/posixmodule.c#L15465 . The issue comes from that eventfd was introduced in 2.6.22, but EFD_CLOEXEC, EFD_NONBLOCK, EFD_SEMAPHORE were introduced in 2.6.26, 2.6.26 and 2.6.30 respectively and which are assumed to be present.

Your environment

I encountered this on Fedora 10 i386 with kernel version 2.6.27 so build was failing on EFD_SEMAPHORE. I tested this on CPython 3.10.5 and this should be an issue in 3.10 since eventfd was introduced in that version I believe.
@gha-xena gha-xena added the type-bug An unexpected behavior, bug, or error label Jun 16, 2022
@kumaraditya303 kumaraditya303 self-assigned this Jul 23, 2022
@kumaraditya303 kumaraditya303 added 3.11 bug and security fixes 3.10 bug and security fixes 3.12 new features, bug and security fixes labels Jul 23, 2022
@bedevere-bot bedevere-bot mentioned this issue Jul 23, 2022
Merged
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this issue Jul 24, 2022
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into pythong…
cd66003 
…h-93899
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this issue Jul 27, 2022
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into pythong…
2b78112 
…h-93899
miss-islington pushed a commit that referenced this issue Jul 27, 2022
@kumaraditya303
GH-93899: fix checks for eventfd flags (GH-95170)
4dd099b
@bedevere-bot bedevere-bot mentioned this issue Jul 27, 2022
Merged
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this issue Jul 27, 2022
@kumaraditya303
[3.11] pythonGH-93899: fix checks for eventfd flags (pythonGH-95170).
a1a745c 
(cherry picked from commit 4dd099b)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@bedevere-bot bedevere-bot mentioned this issue Jul 27, 2022
Merged
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this issue Jul 27, 2022
@kumaraditya303
[3.10] pythonGH-93899: fix checks for eventfd flags (pythonGH-95170).
b8c540d 
(cherry picked from commit 4dd099b)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@erlend-aasland
Copy link
Contributor

Fixed by:

@erlend-aasland
Copy link
Contributor

Thanks for the report, @gha-xena; thanks for the PR, Kumar!

erlend-aasland pushed a commit that referenced this issue Jul 28, 2022
@kumaraditya303
[3.11] GH-93899: fix checks for eventfd flags (GH-95170). (#95342)
7813d97 
(cherry picked from commit 4dd099b)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
erlend-aasland pushed a commit that referenced this issue Jul 28, 2022
@kumaraditya303
[3.10] GH-93899: fix checks for eventfd flags (GH-95170). (#95345)
4ad2229 
(cherry picked from commit 4dd099b)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kumaraditya303 kumaraditya303

Labels
3.10 bug and security fixes 3.11 bug and security fixes 3.12 new features, bug and security fixes type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erlend-aasland @kumaraditya303 @gha-xena