add contacts program by jayam04 · Pull Request #6148 · TheAlgorithms/Python

jayam04 · 2022-05-14T12:53:16Z

Describe your change:

add contacts program, which can save contacts for you

Add an algorithm?
Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2022-05-14T12:53:22Z

+    # CHECK FOR INT OR CHAR A DO AS PER THAT
+    try:
+        a = int(a)
+        tmpVAR = int(KEY[a - 1]) * 1923


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: tmpVAR

ghost · 2022-05-14T12:53:22Z

+        a = int(a)
+        tmpVAR = int(KEY[a - 1]) * 1923
+    except ValueError:
+        tmpVAR = ord(KEY[a - 1]) * 125


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: tmpVAR

ghost · 2022-05-14T12:53:22Z

+
+
+
+def getReminderPLUS(i, c):


Please provide return type hint for the function: getReminderPLUS. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file contacts/encrypt10n.py, please provide doctest for the function getReminderPLUS

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: getReminderPLUS

Please provide type hint for the parameter: i

Please provide descriptive name for the parameter: i

Please provide type hint for the parameter: c

Please provide descriptive name for the parameter: c

ghost · 2022-05-14T12:53:22Z

+
+
+
+def encryptARRAY(array, KEY):


Please provide return type hint for the function: encryptARRAY. If the function does not return a value, please provide the type hint as: def function() -> None:

As there is no test file in this pull request nor any test function or class in the file contacts/encrypt10n.py, please provide doctest for the function encryptARRAY

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: encryptARRAY

Please provide type hint for the parameter: array

Please provide type hint for the parameter: KEY

ghost · 2022-05-14T12:53:26Z

+
+# check encryption status and get array
+encryptionStatus = False
+encryptionKey = input("ENCRYPTION KEY ('noKEY' or is default KEY): ")


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: encryptionKey

ghost · 2022-05-14T12:53:26Z

+if encryptionKey.upper() == 'NOENCRYPTION' or encryptionKey.upper() == '' or encryptionKey.upper() == 'NOKEY':
+    print("your data is not encrypted")
+    print("you can encrypt while saving program")
+    encryptionKey = "noENCRYPTION"


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: encryptionKey

ghost · 2022-05-14T12:53:26Z

+    print("you can encrypt while saving program")
+    encryptionKey = "noENCRYPTION"
+else:
+    encryptionStatus = True


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: encryptionStatus

ghost · 2022-05-14T12:53:26Z

+            stra = input("y/n?  ")
+            try:
+                if stra[0].upper() == 'Y':
+                    encryptionKey = input("create your encryption key ...")


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: encryptionKey

ghost · 2022-05-14T12:53:26Z

+                    print("\n YOUR ENCRYPTION KEY IS", encryptionKey)
+                    print("\n IF YOU FORGET KEY, FORGET YOUR DATA")
+            except IndexError:
+                encryptionKey = 'noENCRYPTION'


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: encryptionKey

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2022-05-15T01:56:43Z

+import pickle
+
+
+def getKEYchar(a, KEY):


As there is no test file in this pull request nor any test function or class in the file contacts/encrypt10n.py, please provide doctest for the function getKEYchar

Please provide return type hint for the function: getKEYchar. If the function does not return a value, please provide the type hint as: def function() -> None:

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: getKEYchar

Please provide type hint for the parameter: a

Please provide descriptive name for the parameter: a

Please provide type hint for the parameter: KEY

ghost · 2022-05-15T01:56:43Z

+
+
+
+def getReminderPLUS(i, c):


As there is no test file in this pull request nor any test function or class in the file contacts/encrypt10n.py, please provide doctest for the function getReminderPLUS

Please provide return type hint for the function: getReminderPLUS. If the function does not return a value, please provide the type hint as: def function() -> None:

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: getReminderPLUS

Please provide type hint for the parameter: i

Please provide descriptive name for the parameter: i

Please provide type hint for the parameter: c

Please provide descriptive name for the parameter: c

ghost · 2022-05-15T01:56:43Z

+
+
+
+def encryptARRAY(array, KEY):


As there is no test file in this pull request nor any test function or class in the file contacts/encrypt10n.py, please provide doctest for the function encryptARRAY

Please provide return type hint for the function: encryptARRAY. If the function does not return a value, please provide the type hint as: def function() -> None:

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: encryptARRAY

Please provide type hint for the parameter: array

Please provide type hint for the parameter: KEY

ghost · 2022-05-15T01:56:43Z

+
+def encryptARRAY(array, KEY):
+    # GET SOME VALUABLE VARIABLES
+    encryptedARRAY = [[] for tmp in range(4)]


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: encryptedARRAY

ghost · 2022-05-15T01:56:43Z

+def encryptARRAY(array, KEY):
+    # GET SOME VALUABLE VARIABLES
+    encryptedARRAY = [[] for tmp in range(4)]
+    totalContacts = len(array[0])


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: totalContacts

ghost · 2022-05-15T01:56:45Z

+    if KEY == 'noENCRYPTION':
+        encryptedARRAY = array
+    else:
+        encryptedARRAY = encryptARRAY(array, KEY)


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: encryptedARRAY

ghost · 2022-05-15T01:56:45Z

+
+
+
+def printallcontacts(arraylen, array):


As there is no test file in this pull request nor any test function or class in the file contacts/functions.py, please provide doctest for the function printallcontacts

Please provide return type hint for the function: printallcontacts. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: arraylen

Please provide type hint for the parameter: array

ghost · 2022-05-15T01:56:45Z

+
+
+
+def addnewcontact(arraylen, array):


As there is no test file in this pull request nor any test function or class in the file contacts/functions.py, please provide doctest for the function addnewcontact

Please provide return type hint for the function: addnewcontact. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: arraylen

Please provide type hint for the parameter: array

ghost · 2022-05-15T01:56:45Z

+
+
+
+def deleteOldContact(arraylen, array):


As there is no test file in this pull request nor any test function or class in the file contacts/functions.py, please provide doctest for the function deleteOldContact

Please provide return type hint for the function: deleteOldContact. If the function does not return a value, please provide the type hint as: def function() -> None:

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: deleteOldContact

Please provide type hint for the parameter: arraylen

Please provide type hint for the parameter: array

ghost · 2022-05-15T01:56:45Z

+
+
+
+def sorTarray(arraylen, array):


As there is no test file in this pull request nor any test function or class in the file contacts/functions.py, please provide doctest for the function sorTarray

Please provide return type hint for the function: sorTarray. If the function does not return a value, please provide the type hint as: def function() -> None:

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: sorTarray

Please provide type hint for the parameter: arraylen

Please provide type hint for the parameter: array

ghost

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Contributing guidelines

Project Euler solution guidelines

Python:

Formatted string literals (f-strings)

Type hints

doctest

unittest

pytest

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

@algorithms-keeper review to trigger the checks for only added pull request files

@algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.

ghost · 2022-06-09T04:15:45Z

+import pickle
+
+
+def getKEYchar(a, KEY):


As there is no test file in this pull request nor any test function or class in the file contacts/encrypt10n.py, please provide doctest for the function getKEYchar

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: getKEYchar

Please provide return type hint for the function: getKEYchar. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide descriptive name for the parameter: a

Please provide type hint for the parameter: a

Please provide type hint for the parameter: KEY

ghost · 2022-06-09T04:15:45Z

+
+
+
+def getReminderPLUS(i, c):


As there is no test file in this pull request nor any test function or class in the file contacts/encrypt10n.py, please provide doctest for the function getReminderPLUS

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: getReminderPLUS

Please provide return type hint for the function: getReminderPLUS. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide descriptive name for the parameter: i

Please provide type hint for the parameter: i

Please provide descriptive name for the parameter: c

Please provide type hint for the parameter: c

ghost · 2022-06-09T04:15:45Z

+
+
+
+def encryptARRAY(array, KEY):


As there is no test file in this pull request nor any test function or class in the file contacts/encrypt10n.py, please provide doctest for the function encryptARRAY

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: encryptARRAY

Please provide return type hint for the function: encryptARRAY. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: array

Please provide type hint for the parameter: KEY

ghost · 2022-06-09T04:15:45Z

+
+def encryptARRAY(array, KEY):
+    # GET SOME VALUABLE VARIABLES
+    encryptedARRAY = [[] for tmp in range(4)]


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: encryptedARRAY

ghost · 2022-06-09T04:15:45Z

+def encryptARRAY(array, KEY):
+    # GET SOME VALUABLE VARIABLES
+    encryptedARRAY = [[] for tmp in range(4)]
+    totalContacts = len(array[0])


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: totalContacts

ghost · 2022-06-09T04:15:46Z

+    if KEY == 'noENCRYPTION':
+        encryptedARRAY = array
+    else:
+        encryptedARRAY = encryptARRAY(array, KEY)


Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: encryptedARRAY

ghost · 2022-06-09T04:15:46Z

+
+
+
+def printallcontacts(arraylen, array):


As there is no test file in this pull request nor any test function or class in the file contacts/functions.py, please provide doctest for the function printallcontacts

Please provide return type hint for the function: printallcontacts. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: arraylen

Please provide type hint for the parameter: array

ghost · 2022-06-09T04:15:46Z

+
+
+
+def addnewcontact(arraylen, array):


As there is no test file in this pull request nor any test function or class in the file contacts/functions.py, please provide doctest for the function addnewcontact

Please provide return type hint for the function: addnewcontact. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: arraylen

Please provide type hint for the parameter: array

ghost · 2022-06-09T04:15:47Z

+
+
+
+def deleteOldContact(arraylen, array):


As there is no test file in this pull request nor any test function or class in the file contacts/functions.py, please provide doctest for the function deleteOldContact

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: deleteOldContact

Please provide return type hint for the function: deleteOldContact. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: arraylen

Please provide type hint for the parameter: array

ghost · 2022-06-09T04:15:47Z

+
+
+
+def sorTarray(arraylen, array):


As there is no test file in this pull request nor any test function or class in the file contacts/functions.py, please provide doctest for the function sorTarray

Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: sorTarray

Please provide return type hint for the function: sorTarray. If the function does not return a value, please provide the type hint as: def function() -> None:

Please provide type hint for the parameter: arraylen

Please provide type hint for the parameter: array

stale · 2022-07-10T09:06:44Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

JymPatel added 2 commits May 14, 2022 17:55

added contacts

615a218

changes to get all checks

bc1de8c

ghost added documentation This PR modified documentation files require descriptive names This PR needs descriptive function and/or variable names require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html labels May 14, 2022

ghost reviewed May 14, 2022

View reviewed changes

made variables in snake case

eff47ad

ghost reviewed May 15, 2022

View reviewed changes

ghost added the awaiting reviews This PR is ready to be reviewed label May 15, 2022

ghost added the tests are failing Do not merge until tests pass label May 26, 2022

Merge branch 'TheAlgorithms:master' into master

d94d2ec

ghost reviewed Jun 9, 2022

View reviewed changes

stale Bot added the stale Used to mark an issue or pull request stale. label Jul 10, 2022

jayam04 closed this Jul 10, 2022

Uh oh!

Conversation

jayam04 commented May 14, 2022

Describe your change:

Checklist:

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper actions can be triggered by commenting on this PR:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment