Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-93521: Filter out __weakref__ slot if present in bases #93535

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Bluenix2
Copy link

@Bluenix2 Bluenix2 commented Jun 6, 2022

This PR fixes #93521 by moving the ('__weakref__',) if weakref_slot else () ternary into the iterator that filters out already present slots.

@Bluenix2 Bluenix2 requested a review from ericvsmith as a code owner Jun 6, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 6, 2022

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

@Bluenix2
Copy link
Author

@Bluenix2 Bluenix2 commented Jun 6, 2022

I am not sure why my commit was changed to pythonGH rather than GH by GitHub...

Lib/test/test_dataclasses.py Show resolved Hide resolved
Lib/test/test_dataclasses.py Show resolved Hide resolved
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Jun 6, 2022

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@Bluenix2 Bluenix2 requested a review from ericvsmith Jun 6, 2022
@Bluenix2
Copy link
Author

@Bluenix2 Bluenix2 commented Jun 6, 2022

Ah sorry I requested your review through GitHub but I'll send a message to be clear. I have addressed your comments and pushed new changes which are passing checks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants