SC2043
Joachim Ansorg edited this page Nov 12, 2021
·
6 revisions
This loop will only ever run once for a constant value. Did you perhaps mean to loop over dir/*, $var or $(cmd)?
Problematic code:
for var in value
do
echo "$var"
doneCorrect code:
Correct code depends on what you want to do.
To iterate over files in a directory, instead of for var in /my/dir use:
for var in /my/dir/* ; do echo "$var"; doneTo iterate over lines in a file or command output, use a while read loop instead:
mycommand | while IFS= read -r line; do echo "$line"; doneTo iterate over words written to a command or function's stdout, instead of for var in myfunction, use
for var in $(myfunction); do echo "$var"; doneTo iterate over words in a variable, instead of for var in myvariable, use
for var in $myvariable; do echo "$var"; doneRationale:
ShellCheck has detected that your for loop iterates over a single, constant value. This is most likely a bug in your code, caused by you not expanding the value in the way you want.
You should make sure that whatever you loop over will expand into multiple words.
Exceptions
None.