Skip to content

/ codeql Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java: Model Android Bundle and Intent extras methods #6739

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Java: Model Android Bundle and Intent extras methods #6739

wants to merge 4 commits into from
+8,399 −669

Conversation

@joefarebrother
Copy link
Contributor

@joefarebrother joefarebrother commented Sep 23, 2021

No description provided.

@joefarebrother
Model Bundle and Intent extra methods
0919042
@joefarebrother joefarebrother requested a review from as a code owner Sep 23, 2021
@github-actions github-actions bot added the Java label Sep 23, 2021
@joefarebrother joefarebrother mentioned this pull request Sep 23, 2021
Open
@smowton
Copy link
Contributor

@smowton smowton commented Sep 23, 2021

Could you run the test generator on these?

@smowton
Copy link
Contributor

@smowton smowton commented Sep 23, 2021

Also looks like there's a real test failure relating to existing modelling of the Activity.getIntent() / Bundle.getExtras() methods. Suggest the old-style models in FlowSources.qll and Intent.qll should be updated/removed at the same time to reduce confusion.

@smowton
Copy link
Contributor

@smowton smowton commented Sep 29, 2021

Nudge @joefarebrother

@joefarebrother
Generate tests and stubs
3ae5f13
@joefarebrother
Add more models; fix tests
5e4498a
@joefarebrother
Remove models.csv
085701c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github/codeql-java codeql-java

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Java
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@joefarebrother @smowton