Skip to content

Update add.py#4666

Closed
Vibhor0 wants to merge 1 commit intoTheAlgorithms:masterfrom
Vibhor0:patch-2
Closed

Update add.py#4666
Vibhor0 wants to merge 1 commit intoTheAlgorithms:masterfrom
Vibhor0:patch-2

Conversation

@Vibhor0
Copy link
Copy Markdown

@Vibhor0 Vibhor0 commented Aug 24, 2021

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@Vibhor0 Vibhor0 requested a review from Kush1101 as a code owner August 24, 2021 19:55
@ghost ghost added awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files labels Aug 24, 2021
@cclauss cclauss closed this Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kush1101 Kush1101 Awaiting requested review from Kush1101

Assignees

No one assigned

Labels

awaiting reviews This PR is ready to be reviewed enhancement This PR modified some existing files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Vibhor0 @cclauss