Minor fixes to specialization stats. #27457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unquickened instructions.
iritkatriel
reviewed
Jul 29, 2021
| @@ -3380,6 +3381,7 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, InterpreterFrame *frame, int thr | |||
| STAT_INC(LOAD_ATTR, deferred); | |||
| cache->adaptive.counter--; | |||
| oparg = cache->adaptive.original_oparg; | |||
| STAT_DEC(LOAD_ATTR, unquickened); | |||
There was a problem hiding this comment.
We don't need this in LOAD_GLOBAL as well?
There was a problem hiding this comment.
These counters are uints. Is there no danger of underflow?
There was a problem hiding this comment.
These counters are uints. Is there no danger of underflow?
Unsigned int underflow is well defined in C (unlike for signed int). So the STAT_DEC followed by the STAT_INC is a no op for all values.
iritkatriel
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
ADAPTIVEinstructions as unquickened as well.