C#: Support suppression comments in XML files#4948
C#: Support suppression comments in XML files#4948rdmarsh2 wants to merge 3 commits intogithub:mainfrom
Conversation
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
LGTM, except I think we should move the logic to the shared XML.qll library.
| /** | ||
| * An alert suppression comment. | ||
| */ | ||
| class SuppressionComment extends XMLComment { |
There was a problem hiding this comment.
It feels like this class and SuppressionScope should be in XML.qll, so it can be reused by other languages.
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
Auto-format check fails.
|
Should this change be documented in a change-note? |
It probably should, yes. |
|
This one seems to have fallen through the cracks. Should it be resurrected, or is it no longer relevant? |
|
Probably worth resurrecting at some point - I think C# is still the only language where our queries report results in XML files, but it's still possible for custom queries to report results in XML for other languages. |
|
Is this still live or can it be closed/drafted? |
7 participants
This adds a new
@kind alert-suppressionquery which handles XML comments and accepts the same format as the existing query for C# comments.