Skip to content

/ ko.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[번역 개선 제안] 2.1 Hello, world! #967

Merged
merged 2 commits into from Jan 5, 2021
Merged

[번역 개선 제안] 2.1 Hello, world! #967

merged 2 commits into from Jan 5, 2021

Conversation

@AETSRound
Copy link
Contributor

@AETSRound AETSRound commented Jan 5, 2021

‘script’ 태그 단락에서,
"어느 곳에나" 라는 표현을 원문과 유사하게
"대부분의 위치에" 라는 표현으로 수정하는 것을 제안드립니다.

Pull Request 체크리스트

TODO

  • 번역 규칙을 확인하셨나요?
    • 줄 바꿈과 단락을 '원문과 동일하게' 유지하셨나요?
    • 맞춤법 검사기로 맞춤법을 확인하셨나요?
    • 마크다운 문법에 사용되는 공백(스페이스), 큰따옴표("), 작은따옴표('), 대시(-), 백틱(`) 등의 특수문자는 그대로 두셨나요?
  • 로컬 서버 세팅 후 최종 결과물을 확인해 보셨나요?
  • PR 하나엔 번역문 하나만 넣으셨나요?
  • 의미 있는 커밋 메시지를 작성하셨나요?
    • 예시
      • [프락시] 번역
      • [프락시] 과제 번역
      • [if문과 조건부 연산자 '?'] 리뷰
      • [주석] 2차 리뷰
      • [Date 객체와 날짜] 번역
AETSRound added 2 commits Jan 5, 2021
@AETSRound
[script 태그에 대한 설명] 수정
3abe58f
@AETSRound
[script 태그에 대한 설명] 수정
Loading status checks…
84c6f88
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-ko Jan 5, 2021
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Jan 5, 2021 •
edited

CLA assistant check
All committers have signed the CLA.
@Violet-Bora-Lee
Copy link
Member

@Violet-Bora-Lee Violet-Bora-Lee commented Jan 5, 2021

감사합니다 바로 머지 진행할게요 👍
@Violet-Bora-Lee Violet-Bora-Lee merged commit eeb268e into javascript-tutorial:master Jan 5, 2021
1 check passed
1 check passed
license/cla Contributor License Agreement is signed.
Details
@AETSRound AETSRound deleted the AETSRound:trslJST branch Jan 6, 2021
@AETSRound
Copy link
Contributor Author

@AETSRound AETSRound commented Jan 6, 2021

Lots of! 😮 Could you share the info about the v2 repository btw?

혹시 어떤걸 의미하는지 자세히 말씀해주실수 있으실까요? 처음 pull request를 해봐서 부족한점이 있어도 너그럽게 봐주시면 감사하겠습니다.
@Violet-Bora-Lee
Copy link
Member

@Violet-Bora-Lee Violet-Bora-Lee commented Jan 6, 2021

Lots of! 😮 Could you share the info about the v2 repository btw?

혹시 어떤걸 의미하는지 자세히 말씀해주실수 있으실까요? 처음 pull request를 해봐서 부족한점이 있어도 너그럽게 봐주시면 감사하겠습니다.

아아 제가 다른데에 달아야할 리플인데 여기에 달았네요 죄송합니다 삭제할게요
@AETSRound AETSRound restored the AETSRound:trslJST branch Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javascript-tutorial/translate-ko translate-ko

Assignees
No one assigned
Labels
review needed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@AETSRound @CLAassistant @Violet-Bora-Lee @javascript-translate-bot
You can’t perform that action at this time.