Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42748: Use exec_module instead of load_module #23954

Merged
merged 3 commits into from Dec 26, 2020
Merged

bpo-42748: Use exec_module instead of load_module #23954

merged 3 commits into from Dec 26, 2020

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Dec 26, 2020 •
edited by bedevere-bot

@corona10 corona10 requested a review from isidentical Dec 26, 2020
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Dec 26, 2020
isidentical
isidentical reviewed Dec 26, 2020
View changes
Copy link
Sponsor Member

@isidentical isidentical left a comment

Instead of creating types.ModuleType by ourselves, can we use importlib.util.module_from_spec? (pass the spec that you already created to this one, and call the result of that with spec.loader.exec_module)

@corona10
Copy link
Member Author

corona10 commented Dec 26, 2020

@isidentical Thanks! I update the PR by reflecting on your review!

@corona10 corona10 requested a review from isidentical Dec 26, 2020
@isidentical isidentical merged commit 0b281f9 into python:master Dec 26, 2020
3 checks passed
@bedevere-bot
Copy link

bedevere-bot commented Dec 26, 2020

@isidentical: Please replace # with GH- in the commit message next time. Thanks!

@isidentical
Copy link
Sponsor Member

isidentical commented Dec 26, 2020

Thanks @corona10!

@corona10 corona10 deleted the bpo-42748 branch Dec 26, 2020
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@corona10 @adorilson
bpo-42748: test_asdl_parser now uses exec_module instead of load_modu…
2b186d6 
…le (python#23954)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isidentical isidentical

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@corona10 @bedevere-bot @isidentical @the-knights-who-say-ni