Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CONTRIBUTING.md for spanish translation #8

Merged
merged 1 commit into from Mar 7, 2019
Merged

Add CONTRIBUTING.md for spanish translation #8

merged 1 commit into from Mar 7, 2019

Conversation

@lizzie136
Copy link
Member

@lizzie136 lizzie136 commented Mar 7, 2019

  • Adds references to communication channels (discord, trello)
  • Refers to contributing GitHub flow
@lizzie136 lizzie136 requested review from caballerof and maurodibert Mar 7, 2019
@caballerof
caballerof suggested changes Mar 7, 2019
View changes
Copy link
Collaborator

@caballerof caballerof left a comment

!
CONTRIBUTING.md Outdated
@@ -0,0 +1,18 @@
# The Modern JavaScript tutorial en Español

Hola! Si quieres contribuir traduciendo este proyecto puedes encontrar el estado

This comment has been minimized.

Sign in to view
@caballerof

caballerof Mar 7, 2019
Collaborator

¡Hola!, si

This comment has been minimized.

Sign in to view
@caballerof

caballerof Mar 7, 2019
Collaborator

Se me paso pero el S va en mayúsculas después del signo, pero me refiero en el cambio a la palabra hola entre el símbolo de apertura y cierre del signo de exclamación.

This comment has been minimized.

Sign in to view
@lizzie136

lizzie136 Mar 7, 2019
Author Member

gracias!
@lizzie136
Add CONTRIBUTING.md for spanish translation
Verified
This commit was signed with a verified signature.
lizzie136 Elizabeth Portilla
GPG key ID: AA072A17559BA76B Learn about signing commits
24ba44e 
  - Add reference to communication channels (discord, trello)
  - Refers to contributing github flow
@lizzie136 lizzie136 force-pushed the contributing branch from b114bbc to 24ba44e Mar 7, 2019
@lizzie136 lizzie136 requested a review from caballerof Mar 7, 2019
@caballerof
caballerof approved these changes Mar 7, 2019
View changes
@lizzie136 lizzie136 merged commit eb3001a into master Mar 7, 2019
javascript-translate-bot pushed a commit that referenced this pull request Apr 26, 2019
@Antiai
#8: fix unordered list
65c5793
javascript-translate-bot pushed a commit that referenced this pull request Apr 26, 2019
@lex111
#8: fix unordered list (#942)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
a9ee52b 
#8: fix unordered list
EzequielCaste pushed a commit that referenced this pull request Aug 31, 2020
@maksumi @vplentinax @joaquinelio
Update (#8)
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
5402692 
* atrrdom

* scrolling

* Update 2-ui/1-document/06-dom-attributes-and-properties/article.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

* Update 2-ui/1-document/06-dom-attributes-and-properties/article.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

* Update 2-ui/1-document/06-dom-attributes-and-properties/article.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

* Update article.md

* Update 2-ui/1-document/06-dom-attributes-and-properties/1-get-user-attribute/task.md

Co-authored-by: joaquinelio <joaquinelio@gmail.com>

Co-authored-by: vplentinax <jc.lerebours.vp@hotmail.com>
Co-authored-by: Valentina VP <34555644+vplentinax@users.noreply.github.com>
Co-authored-by: joaquinelio <joaquinelio@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caballerof caballerof

@maurodibert maurodibert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@lizzie136 @caballerof
You can’t perform that action at this time.