Skip to content

/ es.javascript.info

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Variables #93

Merged
merged 6 commits into from Jun 8, 2020
Merged

Variables #93

merged 6 commits into from Jun 8, 2020

Conversation

@javier123454321
Copy link

@javier123454321 javier123454321 commented Sep 2, 2019

Primera traducción y primera contribución.
Utilizé la segunda persona formal (usted) al referirme al lector del artículo.
Javier Gonzalez Javier Gonzalez
translated variable article into spanish
Loading status checks…
4383447
@javascript-translate-bot javascript-translate-bot requested a review from javascript-tutorial/translate-es Sep 2, 2019
@iliakan iliakan mentioned this pull request Sep 2, 2019
Open
159 of 174 tasks complete
@CLAassistant
Copy link

@CLAassistant CLAassistant commented Sep 2, 2019 •
edited

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ joaquinelio
✅ ezzep66
❌ Javier Gonzalez

Javier Gonzalez seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
@tscandalitta
Copy link
Collaborator

@tscandalitta tscandalitta commented Sep 8, 2019

En el tutorial nos venimos refiriendo al usuario como "tú" y no como "usted". Podrías corregirlo?
@Giorgiosaud
Copy link
Contributor

@Giorgiosaud Giorgiosaud commented Sep 11, 2019

/done
Javier Gonzalez Javier Gonzalez
Cambiar el termino de segunda persona formal a informal (tú)
Loading status checks…
10173c4
@javier123454321
Copy link
Author

@javier123454321 javier123454321 commented Sep 23, 2019

Lamento la demora, aquí estan estas correcciones, espero poder dedicarle mas tiempo en el futuro cercano y poder progresar mas rápido
@joaquinelio
joaquinelio requested changes Jun 3, 2020
View changes
Copy link
Contributor

@joaquinelio joaquinelio left a comment •
edited

@vplentinax o @ezzep66 Revisen, avisen y lo edito y hago merge
Cierto que faltan los ejercicios, pero
Está buena, no rompe estructura, es largo y tradujo hasta los link externos al sitio ES
Oops! ¿Qué tan importante es firmar eso? ¿Propiedad intelectual?
1-js/02-first-steps/04-variables/article.md Show resolved Hide resolved
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jun 3, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
@EzequielCaste
Update 1-js/02-first-steps/04-variables/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
d9e1cf1
@EzequielCaste
Update 1-js/02-first-steps/04-variables/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9109929
@EzequielCaste
Copy link
Contributor

@EzequielCaste EzequielCaste commented Jun 3, 2020

/done
@vplentinax
Copy link
Contributor

@vplentinax vplentinax commented Jun 5, 2020

Se puede hacer merge a esto o no¿? @ezzep66 @joaquinelio
@joaquinelio
joaquinelio requested changes Jun 8, 2020
View changes
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
1-js/02-first-steps/04-variables/article.md Outdated Show resolved Hide resolved
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jun 8, 2020

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻
joaquinelio added 2 commits Jun 8, 2020
@joaquinelio
Update 1-js/02-first-steps/04-variables/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
940457e
@joaquinelio
Update 1-js/02-first-steps/04-variables/article.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
84230b9
@joaquinelio joaquinelio merged commit f74c8ae into javascript-tutorial:master Jun 8, 2020
1 check was pending
1 check was pending
license/cla Contributor License Agreement is not signed yet.
Details
@javascript-translate-bot
Copy link

@javascript-translate-bot javascript-translate-bot commented Jun 8, 2020

Thank you 💖 I updated the Progress Issue #17 🎉 🎉 🎉
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EzequielCaste EzequielCaste

@joaquinelio joaquinelio

Assignees
No one assigned
Labels
changes requested
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
@javier123454321 @CLAassistant @tscandalitta @Giorgiosaud @javascript-translate-bot @EzequielCaste @vplentinax @joaquinelio
You can’t perform that action at this time.