Skip to content

/ devguide

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ast.unparse to grammar change checklist #567

Merged
merged 3 commits into from Jan 29, 2020
Merged

Add ast.unparse to grammar change checklist #567

merged 3 commits into from Jan 29, 2020

Conversation

@isidentical
Copy link
Member

@isidentical isidentical commented Jan 28, 2020

Now, with the exposed ast.unparse interface it is more important then a standard Tool/ script and needs to reflect changes in the ast.
@isidentical
Add ast.unparse to grammar change checklist
Loading status checks…
b3ee66a
@terryjreedy terryjreedy requested review from benjaminp and pablogsal Jan 28, 2020
@pablogsal
pablogsal reviewed Jan 28, 2020
View changes
grammar.rst Outdated Show resolved Hide resolved
@pablogsal
pablogsal reviewed Jan 28, 2020
View changes
grammar.rst Outdated Show resolved Hide resolved
@pablogsal
pablogsal requested changes Jan 28, 2020
View changes
Copy link
Member

@pablogsal pablogsal left a comment

Some minor nits to the wording
isidentical and others added 2 commits Jan 28, 2020
@isidentical @pablogsal
Apply suggestions from code review
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f46f88a 
Co-Authored-By: Pablo Galindo <Pablogsal@gmail.com>
@isidentical
fix whitespace
Loading status checks…
d8954ed
@isidentical
Copy link
Member Author

@isidentical isidentical commented Jan 28, 2020

Thanks for the suggestions @pablogsal
@isidentical isidentical requested a review from pablogsal Jan 28, 2020
@pablogsal
pablogsal approved these changes Jan 29, 2020
View changes
@pablogsal pablogsal merged commit e1d2dac into python:master Jan 29, 2020
6 checks passed
6 checks passed
Header rules No header rules processed
Details
Pages changed 3 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
opensource-assist added a commit to opensource-assist/devguide that referenced this pull request Jan 29, 2020
@opensource-assist
Merge pull request #1 from python/master
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
da74956 
Add ast.unparse to grammar change checklist (python#567)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

@benjaminp benjaminp

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@isidentical @pablogsal @the-knights-who-say-ni
You can’t perform that action at this time.