Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #3944 authentication error #3949

Merged
merged 15 commits into from Nov 25, 2020
Merged

Conversation

@lawric1
Copy link
Contributor

@lawric1 lawric1 commented Nov 24, 2020

Fixes: #3944

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
@algorithms-keeper
Copy link

@algorithms-keeper algorithms-keeper bot commented Nov 24, 2020

Pull Request Report

@lawric1 Hello! I'm a bot made to check all the pull request Python files. First of all, I want to say thank you for your time and interest in this project and for opening a pull request.

I have detected errors in some of the Python files submitted in this pull request. Please read through the report and make the necessary changes. You can take a look at the relevant links provided after the report.

What are node paths?

The report contain headings and a checklist where the items are paths to the class/function/parameter where the error is present. Node paths are double colon :: separated names and can be any of the following format:

  • Class path: [file_name]::[class_name]
  • Function path: [file_name]::[function_name]
  • Function parameter path: [file_name]::[function_name]::[parameter_name]
  • Method path: [file_name]::[class_name]::[function_name]
  • Method parameter path: [file_name]::[class_name]::[function_name]::[parameter_name]

Following functions require tests [doctest/unittest/pytest]:

  • web_programming/fetch_github_info.py::fetch_github_info

Relevant links:

Copy link
Member

@dhruvmanila dhruvmanila left a comment

Please read the GitHub REST API documentation and apply the requested changes.

Combine the module-level docstring into one and that should come first, before any of the imports.

web_programming/fetch_github_info.py Outdated Show resolved Hide resolved
web_programming/fetch_github_info.py Outdated Show resolved Hide resolved
web_programming/fetch_github_info.py Outdated Show resolved Hide resolved
web_programming/fetch_github_info.py Outdated Show resolved Hide resolved
lawric1 added 2 commits Nov 24, 2020
…tHub REST API standards
web_programming/fetch_github_info.py Outdated Show resolved Hide resolved
web_programming/fetch_github_info.py Outdated Show resolved Hide resolved
web_programming/fetch_github_info.py Outdated Show resolved Hide resolved
web_programming/fetch_github_info.py Outdated Show resolved Hide resolved
lawric1 added 2 commits Nov 24, 2020
@lawric1
Copy link
Contributor Author

@lawric1 lawric1 commented Nov 24, 2020

Thanks for all the feedback, this is my first time contributing and i'm learning a lot

Copy link
Member

@dhruvmanila dhruvmanila left a comment

Thank you for doing this and I hope you learned a lot. I added a test for this function using monkeypatch from pytest. If you have any doubt regarding the tests, please feel free to ask as it is difficult to write tests for web programming, especially for beginners.

@dhruvmanila dhruvmanila merged commit 098f02b into TheAlgorithms:master Nov 25, 2020
2 checks passed
2 checks passed
build
Details
pre-commit
Details
@lawric1 lawric1 deleted the lawric1:hotfix/fetch-github branch Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.